Closed torkjels closed 1 year ago
Heeeeyyy! 😃 👋 🎉
I visited www.masifunde.de for old times' sake and saw that the cookie accept button was broken. When you rewrote the buttons to Typescript it seems like it broke after the props spreading was removed here https://github.com/futurice/masifunde-fe/commit/1b5ddc31487e065158ce7fd6f740424561362457#diff-bca960114d989aae0a5da8b37c4a91cd15bf76058f0e0d5340317ddcbca861daL24 . Additionally the PrivacyPolicyButton and AcceptButton tried using type instead of variant, so the accept button had the wrong color.
PrivacyPolicyButton
AcceptButton
type
variant
Cool to see that this is still being maintained, hope you're doing well! 😃
Production right now ("OK" button in the cookie notice is red and does not work):
With my fix:
Heeeeyyy! 😃 👋 🎉
I visited www.masifunde.de for old times' sake and saw that the cookie accept button was broken. When you rewrote the buttons to Typescript it seems like it broke after the props spreading was removed here https://github.com/futurice/masifunde-fe/commit/1b5ddc31487e065158ce7fd6f740424561362457#diff-bca960114d989aae0a5da8b37c4a91cd15bf76058f0e0d5340317ddcbca861daL24 . Additionally the
PrivacyPolicyButtonandAcceptButtontried usingtypeinstead ofvariant, so the accept button had the wrong color.Cool to see that this is still being maintained, hope you're doing well! 😃
Production right now ("OK" button in the cookie notice is red and does not work):
With my fix: