futurice / pepperoni-app-kit

Pepperoni - React Native App Starter Kit for Android and iOS
http://getpepperoni.com
MIT License
4.63k stars 643 forks source link

Update .travis.yml #185

Closed duddu closed 7 years ago

duddu commented 7 years ago

Support multiple node.js jobs and minor optimizations

duddu commented 7 years ago

Unfortunately, travis doesn't pre-install yarn if an install phase is specified (see build #243), so I don't find another quick way to accomplish the second point for the moment. I made a second commit reverting to explicit install phase for android/ios

krivachy commented 7 years ago

Thank you @duddu! The changes look good and make sense. Off the top of my head I'm not quite sure either if NODE_ENV=test is used, but let's just leave it there just in case ;) Out of curiosity, why do you need node_js: false for the android/ios parts?

duddu commented 7 years ago

Yeah sorry I forgot to mention! The node_js=false are not really required, they just overwrite the property on main job, telling travis not to start the machine searching for node versions. They can be removed, the only real consequence is having a messed up job name for matrix jobs, like "Node.js 6.9,7.1 JDK: oraclejdk7" (multi-language matrix isn't really a standard yet...), though the job itself isn't affected. But If you prefer to remove them for code clarity I understand!

krivachy commented 7 years ago

No let's keep it, having clear job names is good.