futurice / pepperoni-app-kit

Pepperoni - React Native App Starter Kit for Android and iOS
http://getpepperoni.com
MIT License
4.63k stars 645 forks source link

Fix HMR on Android with patched redux-loop using Symbol ponyfill #192

Closed FruitieX closed 7 years ago

FruitieX commented 7 years ago
import 'es6-symbol/implement';

This line in index.android.js proved problematic as it breaks hot module reloading on Android. redux-loop requires it to be present though, as the Android JS engine does not provide ES6 Symbol (unlike the iOS counterpart).

Fix hot module reloading for now by patching redux-loop to use the ES6 Symbol ponyfill. Hopefully soon ES6 Symbol will be implemented in the Android JS engine, and this problem won't exist anymore.

Here is the change made to redux-loop.

krivachy commented 7 years ago

Slightly related to #178 so linking them.