search

fuwaneko / node-protobuf

Google Protocol Buffers wrapper for Node.js [UNMAINTAINED]
180 stars 42 forks source link

fixed binding.gyp syntax errors #1

Closed VanCoding closed 11 years ago

VanCoding commented 11 years ago

Since the syntax errors in bindings.gyp made node-gyp throw errors instead of building, I decided to remove them. Now, node-protobuf builds successfully with node-gyp.

I hope you pull in this fix, because installing the rethinkdb module fails because of the errors while building.

fuwaneko commented 11 years ago

Strange, I tested under Ubuntu, and some people successfully installed on Mac. Maybe your node/node-gyp is too old. But I merge this, thanks.

fuwaneko commented 11 years ago

Strange, I tested under Ubuntu, and some people successfully installed on Mac. Maybe your node/node-gyp is too old. But I merge this, thanks.

VanCoding commented 11 years ago

I'm testing under debian and have the newest version of node-gyp. I don't know why it behaves differently, but it sadly does :(

VanCoding commented 11 years ago

Installing the module over npm now works like a charm, thanks :)

fuwaneko commented 11 years ago

@VanCoding Hmm, I published updated package just now. Are you sure there was a problem with binding.gyp?

VanCoding commented 11 years ago

Yup, I checked the binding.gyp of the module I got from npm and it contains my changes.