fuwaneko / node-protobuf

Google Protocol Buffers wrapper for Node.js [UNMAINTAINED]
180 stars 42 forks source link

node-protobuf does not compile against the latest version of node #18

Closed AtnNn closed 9 years ago

AtnNn commented 10 years ago

Here are some of the compile errors:

../protobuf.cpp: At global scope:
../protobuf.cpp:19:13: error: namespace ‘node::Buffer’ not allowed in using-declaration
 using node::Buffer;
             ^
../protobuf.cpp:33:38: error: ‘Arguments’ does not name a type
   static Handle<v8::Value> New(const Arguments &args);

Here is a patch that fixes most of these problems:

https://github.com/atnnn/node-protobuf/commit/2f90605146bf6f69080646da4440eb9f0f4ae7ee

wentianle commented 10 years ago

this version fixes https://github.com/wentianle/node-protobuf

AtnNn commented 10 years ago

@wentianle I get the same compile errors with node 0.10.11 and your repository.

fuwaneko commented 10 years ago

@atnnn 0.11 is not stable version. Current latest stable is 0.10.24 until 0.12 goes live. I suppose if I add those "fixes" stable will break so I won't until 0.12.

AtnNn commented 10 years ago

@fuwaneko That makes a lot of sense.

fuwaneko commented 10 years ago

@AtnNn v1.2.0 should compile and work with v0.11.13 (but not earlier v0.11). Could you test it, please?