seg fault when i parse required bytes field

[AlexMarlo]

i have package message;

message Notification { required string date = 1; required bytes message = 2; } where message is another nested serialized proto message

on parse first parse is ok but when i parse nested message i have seg fault when i use npm project "protobuf" everything is ok

[fuwaneko]

I'm not sure what you're trying to do. Could you clarify a little bit?

[AlexMarlo]

i've sent you pull request wich fix this bug https://github.com/fuwaneko/node-protobuf/pull/5

[AlexMarlo]

looks like there is incorrect work with bytes fields while serialization and parse

[fuwaneko]

So, why are you trying to serialize one message and put serialized data inside another? You could just do

message B {
...
}
message A {
    required B message_b = 1;
}

As for serializing node.js Buffers I don't think node-protobuf should do this, it's aim is to work with plain simple objects. But if it's trivial to implement, I'll add this functionality.

[AlexMarlo]

i showed only little problem for real we have very big hierarchy when Message is root and in one nested object it should store Message it self thats why we chose to store it as serialized object to avoid circular dependency

[fuwaneko]

Ah, that's a good reason, I didn't think about such scenario. Anyways, your pull request is merged, so you can close this issue if it's solved.

[AlexMarlo]

thanks, it also will be very good, if you'll update package in npm repo ASAP ))

[fuwaneko]

@AlexMarlo Just updated npm.

[AlexMarlo]

Big Thanks)