search

fuwaneko / node-protobuf

Google Protocol Buffers wrapper for Node.js [UNMAINTAINED]
181 stars 42 forks source link

build: fix build on Solaris #46

Closed misterdjules closed 9 years ago

misterdjules commented 9 years ago

The current binding.gyp file adds the same NAN headers directory to the compiler's command line for Linux, Windows and OSX, but not for Solaris.

This results in node-protobuf not building on Solaris and platforms derived from Solaris, like SmartOS.

This change fixes this problem by always adding NAN's headers directory to the compiler's command line, regardless of the platform.

misterdjules commented 9 years ago

Thank you for merging this @fuwaneko, this is much appreciated!