Closed BryanDonovan closed 8 years ago
Yes, it need to be updated to latest NaN.
That doesn't seem to fix it: https://gist.github.com/BryanDonovan/3a9a4dd627a056bac99a
(using nan
version 2.0.9).
@BryanDonovan obviously, because the code needs to be updated, not just the package.
Thanks. I thought you just meant that the nan
package needed to be updated.
@BryanDonovan I've updated node-protobuf to work with Node v4.1.1. Hope this helps: https://github.com/fuwaneko/node-protobuf/pull/49
Guys, is it make sense to update major version of the project? Because I've just got the update from 1.2.7 to 1.2.8 and now I can't compile the module with node 0.10.40
@jhony-chikens is it impossible to update for 0.12? It's the latest stable in pre-4.0.0 world.
@fuwaneko in my case it kind of complicated mostly because of some other dependencies. But I am just talking about semantic versions and breaking changes. For me it's not such a big problem. It's also possible for me just to freeze the version on 1.2.7
@jhony-chikens in that case, yes, it's better to freeze on 1.2.7. Sorry for non-semantic version update.
@jhony-chikens Check 1.2.9, it should work with 0.10 and also includes fix for int64.
@fuwaneko thank you a lot
Hi,
node-protobuf
fails to compile on Mac OS (10.10.5) using Node 4.x. Here's a gist with thenpm install
output fornode-protobuf
1.2.7 using Node 4.1.0:https://gist.github.com/BryanDonovan/0fd216f379b4b857971a