fuwaneko / node-protobuf

Google Protocol Buffers wrapper for Node.js [UNMAINTAINED]
180 stars 42 forks source link

The bindings.gyp in the npm package contains dos style newlines (^M) #8

Closed AtnNn closed 10 years ago

AtnNn commented 10 years ago

This causes the installation to fail in certain environments. On centos 6.4 for example:

# npm install node-protobuf
> node-protobuf@1.0.5 install /root/node_modules/rethinkdb/node_modules/node-protobuf
> node-gyp rebuild

npm http GET https://registry.npmjs.org/ascli
npm http GET https://registry.npmjs.org/bytebuffer
Traceback (most recent call last):
  File "/usr/bin/gyp", line 18, in <module>
    sys.exit(gyp.main(sys.argv[1:]))
  File "/usr/lib/python2.6/site-packages/gyp/__init__.py", line 462, in main
    options.circular_check)
  File "/usr/lib/python2.6/site-packages/gyp/__init__.py", line 100, in Load
    depth, generator_input_info, check, circular_check)
  File "/usr/lib/python2.6/site-packages/gyp/input.py", line 2255, in Load
    depth, check)
  File "/usr/lib/python2.6/site-packages/gyp/input.py", line 362, in LoadTargetBuildFile
    includes, True, check)
  File "/usr/lib/python2.6/site-packages/gyp/input.py", line 217, in LoadOneBuildFile
    None)
  File "binding.gyp", line 1
    {
     ^
SyntaxError: invalid syntax

I downloaded http://registry.npmjs.org/node-protobuf/-/node-protobuf-1.0.5.tgz and ran dos2unix on bindings.gyp. I was then able to install the package.

The following rpm packages were used:

python-2.6.6-36.el6.x86_64
gyp-0.1-0.6.1010svn.el6.noarch
npm-1.3.3-1.el6.noarch
nodejs-0.10.16-1.el6.x86_64
node-gyp-0.10.6-1.el6.noarch
fuwaneko commented 10 years ago

Updated npm, should work now.

AtnNn commented 10 years ago

It does indeed work.

Thanks for the quick fix.