search

fuxialexander / org-pdftools

A custom org link type for pdf-tools
GNU General Public License v3.0
335 stars 36 forks source link

Note about README.org #21

Closed jwiegley closed 4 years ago

jwiegley commented 4 years ago

use-package does support an :after keyword that means eval-after-load.

fuxialexander commented 4 years ago

So 

(use-package org-pdftools
  :config (setq org-pdftools-root-dir /path/you/store/pdfs
                org-pdftools-search-string-separator "??")
  (with-eval-after-load 'org
    (org-link-set-parameters "pdftools"
                             :follow #'org-pdftools-open
                             :complete #'org-pdftools-complete-link
                             :store #'org-pdftools-store-link
                             :export #'org-pdftools-export)
    (add-hook 'org-store-link-functions 'org-pdftools-store-link)))

and 

(use-package org-pdftools
  :config (setq org-pdftools-root-dir /path/you/store/pdfs
                org-pdftools-search-string-separator "??")
  :after (org)
    (org-link-set-parameters "pdftools"
                             :follow #'org-pdftools-open
                             :complete #'org-pdftools-complete-link
                             :store #'org-pdftools-store-link
                             :export #'org-pdftools-export)
    (add-hook 'org-store-link-functions 'org-pdftools-store-link)))

are equivalent?

jwiegley commented 4 years ago

More like:

(use-package org-pdftools
  :init (setq org-pdftools-root-dir /path/you/store/pdfs
                org-pdftools-search-string-separator "??")
  :after org
  :config
    (org-link-set-parameters "pdftools"
                             :follow #'org-pdftools-open
                             :complete #'org-pdftools-complete-link
                             :store #'org-pdftools-store-link
                             :export #'org-pdftools-export)
    (add-hook 'org-store-link-functions 'org-pdftools-store-link)))

This says: After org has loaded, load org-pdftools. Once it's done loading, run the :config commands to hook it up to org.

fuxialexander commented 4 years ago

@jwiegley Oh thanks a lot! I'll update the README accordingly.

fuxialexander commented 4 years ago

fixed in https://github.com/fuxialexander/org-pdftools/commit/6a519562116c1d165226762631fa9d40efe48fd7

also org-noter-pdftools has been PRed to MELPA https://github.com/melpa/melpa/pull/6813