search

fuxialexander / org-pdftools

A custom org link type for pdf-tools
GNU General Public License v3.0
335 stars 36 forks source link

org-pdftools-store-link: fix link isearch string match #30

Closed kamidon closed 4 years ago

kamidon commented 4 years ago

The pdftools link format uses the string "??" to separate the isearch string match portion of the link. The regular expression used to extract that string in org-pdftools-store-link before this commit did not quote these question marks so that they specify zero or one of the previous item rather than literal question marks, resulting in the entire link always matching and being used for the "Quoting" section of the default description.

fuxialexander commented 4 years ago

Ah, thanks for the catch! It should also respect the user customization. Now fixed!

kamidon commented 4 years ago

Cool. Thanks for better fix. I didn't realize that could be customized.