Closed mohkale closed 4 years ago
Ah...sorry for the loss... Also thanks for the catch!
Thnx, great work as always 😄.
Wait, I don't think I was clear enough. That's my bad. You've concatenated both 2nd and 3rd argument to replace-regexp-in-string
which means it's not being passed enough arguments and ends up throwing an error.
Here's a diff of how it should look.
(concat
(replace-regexp-in-string
"^file:"
- org-pdftools-link-prefix ":"
+ (concat
+ org-pdftools-link-prefix ":")
(org-link-complete-file arg))
"::"
(read-from-minibuffer
"Page:"
Hope I get it right this time 😂
yep, seems to be working again. :+1:.
I just found out all the links I made yesterday were unusable :cry:.Here's the current body of the function.
the
org-pdftools-link-prefix ":"
part should beoutside of the replace regexp in stringconcatenated together as(concat org-pdftools-link-prefix ":")
. as it stands, this always outputs":::1"
.