search

fuzan / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Rietveld should forward vacation responses #395

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Be the OWNER of some bit of code.
2. Turn on a vacation email auto-responder.
3. Go on vacation.

What is the expected output? What do you see instead?

Expected: Other developers that ask you for code reviews will learn that you 
are on vacation and promptly find a different reviewer or otherwise work around 
your absence.

Actual: Other developers are irritated about your failure to respond. They ping 
you multiple times via Rietveld and their work is delayed until they finally 
send you a direct email asking What's Up? and get your vacation auto-response.

*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***
erikwright@ Google

An alternative solution would be to allow a vacation bit to be set in Rietveld.

Original issue reported on code.google.com by erikwright@chromium.org on 14 Sep 2012 at 2:39

GoogleCodeExporter commented 9 years ago 
I understand you are frustrated.  But what change do you want for Rietveld?  
Adding a "vacation" feature to every product that sends or receives email won't 
scale (people would forget to turn it on or off).

Original comment by gvanrossum@gmail.com on 14 Sep 2012 at 2:45

GoogleCodeExporter commented 9 years ago 
The preferred solution is that Rietveld (or perhaps AppEngine) doesn't swallow 
the auto-response message that it is being sent from the user's email client.

Here is the response my client (GMail) sent to a code review:

Date: Mon, 27 Aug 2012 11:22:47 -0700
From: "Erik Wright" <erikwright@chromium.org>
To: 
38ro7UBUJAN0BGQNLHTLBNCDQDUHDV-GQFL9HK.BNL@2uix4h7xygsz66weerlq.apphosting.bounc
es.google.com
Message-ID: <CAGjM5nhrmtzLshLZcroxXKD0dW0Vw9e-Bmpu04Zxh7r9B9sahw@mail.gmail.com>
Subject: On Holiday Re: string_util support for joining strings using strings 
not just chars. (issue 10828217)
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Precedence: bulk
X-Autoreply: yes
Auto-Submitted: auto-replied

The "To:" address in this case corresponds to the "Return-Path:" address in the 
original codereview email.

My original assumption was that Rietveld was discarding these messages, but I 
have investigated further and it seems that AppEngine itself does this. See the 
following issue:

http://code.google.com/p/googleappengine/issues/detail?id=7451

Clearly, Rietveld can't do anything about that.

Original comment by erikwright@chromium.org on 14 Sep 2012 at 3:14