search

fuzan / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Can't parse to chunks #420

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Visit https://chromereviews.googleplex.com/6675017/
2. Press view to see the diff for test_fft_time.c
3.

What is the expected output? What do you see instead?

I was expecting a diff (for a completely new file).  Instead, it says "Can't 
parse the patch to chunks".

What browser are you using?  What version? On what operating system?

Chrome version 25.0.1364.45 beta on linux ubuntu 12

This seems possibly related to 
https://code.google.com/p/rietveld/issues/detail?id=28

Original issue reported on code.google.com by rtoy@chromium.org on 1 Feb 2013 at 12:17

GoogleCodeExporter commented 9 years ago 
Forgot to add that I used git cl upload to upload the patch.

Original comment by rtoy@chromium.org on 1 Feb 2013 at 12:18

GoogleCodeExporter commented 9 years ago 
The server logs include the message:
internal/webrtc/common_audio/signal_processing/internal/arm_fft/test/test_fft_ti
me.c:264: last chunk has incorrect length

The last chunk has a header of
@@ -0,0 +1,1076 @@
and there do seem to be 1076 lines following that, each of which starts with a 
"+".
However, I noticed that one line as a formfeed character (control-L escaped as 
\x0c).  

It turns out that 'a\x0c\nb\n'.splitlines(True) = ['a\0x0c\n', 'b\n'], but with 
unicode strings
u'a\x0c\nb\n'.splitlines(True) = ['a\0x0c', '\n', 'b\n']
That separated out '\n' causes the patch parsing code to think that it reached 
the end of file early, and of course the line counts don't match the expected 
values.

Original comment by jrobbins@google.com on 11 Jul 2014 at 10:55

GoogleCodeExporter commented 9 years ago 
CL sent
https://codereview.appspot.com/112170043/

Original comment by jrobbins@google.com on 11 Jul 2014 at 11:34