search

fuzan / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Is there a plan to add images for review #444

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It would be really useful if rietveld could support reviewing image files. Is 
it part of the roadmap ? Does anyone else think this feature is important ?

Original issue reported on code.google.com by sharoon....@openlabs.co.in on 16 May 2013 at 10:15

GoogleCodeExporter commented 9 years ago 
That works already! Here's an example review I've just uploaded: 
https://codereview.appspot.com/9339048/diff/1/static/opentriangle.gif

Please reopen the issue if you still miss something.

Original comment by albrecht.andi on 16 May 2013 at 12:51

GoogleCodeExporter commented 9 years ago 
Still does not seem to be working for me. I use git as VCS, could it be 
something to do with that ? are there any special options required ?

Original comment by sharoon....@openlabs.co.in on 16 May 2013 at 3:19

GoogleCodeExporter commented 9 years ago 
I've uploaded a second test issue from a git repository: 
https://codereview.appspot.com/9450043/diff/1/opentriangle.gif

It still works. What kind of error do you see?

Original comment by albrecht.andi on 16 May 2013 at 7:38

GoogleCodeExporter commented 9 years ago 
it certainly looks like I am missing something really obvious. Here is an 
upload I made from s git repo: https://codereview.appspot.com/9383044/

Could you paste the arguments you used with upload.py ?

Original comment by sharoon....@openlabs.co.in on 17 May 2013 at 3:33

GoogleCodeExporter commented 9 years ago 
This is what I've done to upload the image diff:

$ mkdir repo
$ cd repo/
$ git init
$ cp ~/devel/rietveld/static/opentriangle.gif .
$ git add opentriangle.gif
$ git commit -m "Initial commit."
$ cp ~/devel/rietveld/static/closedtriangle.gif opentriangle.gif 
$ git commit -m "Change imaged." -a
$ upload.py -y -m "Test, plz ignore" HEAD HEAD^1

Original comment by albrecht.andi on 17 May 2013 at 5:35

GoogleCodeExporter commented 9 years ago 
Thank you for being really helpful, the issue was that the upload.py file I had 
was buggy

Original comment by sharoon....@openlabs.co.in on 17 May 2013 at 6:08