search

fuzan / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

rietveld does not highlight syntax of source code. #479

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
After years working with it, I realized this subtle difference that makes even 
harder to review new code.

Compare 
https://chromium-review.googlesource.com/#/c/189203/1/powerd/policy/external_bac
klight_controller.cc to 
https://codereview.chromium.org/186883002/diff/190001/content/child/blink_platfo
rm_impl.cc

The gerrit version uses 
https://code.google.com/p/google-code-prettify/source/browse/trunk/src/prettify.
css while rietveld shows source code in plain black on white!!

That a entire new file and you can see how bad it is:
https://codereview.chromium.org/166903009/diff/1100001/content/shell/renderer/te
st_runner/event_sender.cc
:(

Original issue reported on code.google.com by tfar...@chromium.org on 8 Mar 2014 at 3:01