search

fuzan / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

links get %-escaped and don't work #483

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Please see https://codereview.chromium.org/203853003/:

When I pasted this link:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%2BL
San%20Tests%20%282%29&number=602

It was escaped to:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%2520ASan%2
52BLSan%2520Tests%2520%25282%2529&number=602

(% was converted to %25)

Original issue reported on code.google.com by yzs...@chromium.org on 18 Mar 2014 at 7:10

GoogleCodeExporter commented 9 years ago 
https://code.google.com/p/rietveld/issues/detail?id=349 claims this has been 
fixed, but we need to merge it into our rietveld instance?

Original comment by thestig@chromium.org on 18 Mar 2014 at 7:17

GoogleCodeExporter commented 9 years ago 
I am thinking that I will merge in 
https://code.google.com/p/rietveld/source/detail?r=d764099e14e49f11d1a848aa63ba8
88559112094
to upgrade the chromium branch of rietveld to django 1.4.

Original comment by jrobbins@google.com on 18 Mar 2014 at 7:38

GoogleCodeExporter commented 9 years ago 
sgtm!

Original comment by iannucci@chromium.org on 18 Mar 2014 at 8:03

GoogleCodeExporter commented 9 years ago 
Right, the escaping issues was a bug in Django and fixed in Django 1.4.

Original comment by albrecht.andi on 18 Mar 2014 at 8:33

GoogleCodeExporter commented 9 years ago 
Dropping another example with giving a star :-)
https://codereview.chromium.org/203593008/

Original comment by morr...@chromium.org on 19 Mar 2014 at 5:37

GoogleCodeExporter commented 9 years ago 
Jason, do you think we could prioritize performing the merge in question? This 
issue is having a terrible effect on usability.

Original comment by eng...@chromium.org on 24 Mar 2014 at 1:16

GoogleCodeExporter commented 9 years ago 
I expect to land this change tomorrow and deploy it the next day or so.

Original comment by jrobb...@chromium.org on 24 Mar 2014 at 1:54

GoogleCodeExporter commented 9 years ago 
This change is live now.
I tested it and I no longer see double-escaping of % in new comments.

However, old comments are unchanged and still have the double escaping.

Original comment by jrobbins@google.com on 26 Mar 2014 at 3:51