fuzetsu / userscripts

Various browser userscripts I created/maintain
25 stars 11 forks source link

Kitsu MAL Rating patch #3

Closed kazzarin closed 7 years ago

kazzarin commented 7 years ago

Fixes some remaining issues:

fuzetsu commented 7 years ago

Looks good, but testing it out, I found this issue. Happens when switching to a page that doesn't have a kitsu rating bar from a page that has both.

image

I think it's a timing issue, because it doesn't happen everytime, if the URL changes before the content gets switched out barCheck thinks there's a bar, but there isn't one by the time App.getMalLink completes.

fuzetsu commented 7 years ago

I'll merge it because it's still better than the current live version, but would be good to sort out the timing issues. Sometimes if you go to another page and it swaps out the content too slowly the bar on the current page will get updated, and then removed when it finally swaps out the content.

kazzarin commented 7 years ago

Sorry about that. I think some recent changes with the way media pages are loaded sped things up making the bug much more apparent since my testing from a couple days ago didn't show anything unusual.

fuzetsu commented 7 years ago

Makes sense, and thanks again for the pulls.