search

fuzionnz / webform_civicrm_migrate

0 stars 6 forks source link

Undefined $default_settings in addCiviCRMHandler() #1

Closed herbdool closed 1 year ago

herbdool commented 1 year ago

$default_settings isn't defined: https://github.com/fuzionnz/webform_civicrm_migrate/blob/63b45fd3039cfd7dbfe52b27d35f6067a6fe69da/src/EventSubscriber/WebformCivicrmMigrateSubscriber.php#L542

I haven't tested the module yet so we'll see how much of a problem this is.

stesi561 commented 1 year ago

Hmm. My guess is that this just means the default settings are not being set - but perhaps they are getting set anyway elsewhere which is why I missed this!

Good spotting.

stesi561 commented 1 year ago

@herbdool I've pushed up a few tweaks. That include fixing the above.