search

fuzzball-muck / fuzzball

Ongoing development of the Fuzzball MUCK server software and associated functionality.
Other
46 stars 26 forks source link

Wizards can GUEST themselves, but can't un-GUEST themselves #685

Closed tanabi closed 8 months ago

tanabi commented 1 year ago

This one was reported to me, I haven't tried to reproduce it yet due to its 'destructive' nature but I'm sure it's true:

To quote:

....

As a wizard, I set the guest flag on myself, then couldn't remove it.

But maybe should consider not allowing guest flag to be set on a player who is already wizard. Or I suppose letting a guest-flagged wizard unguest flag themselves.

...

An untested but possibly big issue is perhaps One could guest themselves and maybe not be able to unguest themselves depending on how the code is written and if the MUCK is compiled with GODPRIV or not.

My feeling is that a wizard should be able to GUEST themselves if they want to (as it may be useful for, say, debugging purposes or otherwise) but should be able to un-GUEST themselves rather than to block them from being GUEST-ed. This enables the most flexibility and I don't think has any particular downsides.

wyld-sw commented 1 year ago

Confirmed, as once you're set G, you can no longer use the @set command. Should Wizards bypass the "Guests are not allowed to XXXXX." logic entirely, or just for @set?

aidanPB commented 1 year ago

I think ideally Wizards should bypass the logic only for setting themselves !G, even, requiring them to un-GUEST themselves before setting or unsetting any other flags or properties. That might be more complicated than it's worth, though.

On Tue, Apr 11, 2023 at 11:29 AM wyld-sw @.***> wrote:

Confirmed, as once you're set G, you can no longer use the @set command. Should Wizards bypass the "Guests are not allowed to XXXXX." logic entirely, or just for @set?

— Reply to this email directly, view it on GitHub https://github.com/fuzzball-muck/fuzzball/issues/685#issuecomment-1503887427, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXGXFC4JSOXFRNU7HOHO3LXAWPG7ANCNFSM6AAAAAAW2LADJY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tanabi commented 1 year ago

I agree with @aidanPB ... it has the most utility if Wizards, once G, can only !G

I also agree that if that is hard to do for some reason, let's just open up @set to Wizards.