fuzziqersoftware / newserv

Phantasy Star Online game server, proxy, and reverse-engineering tools
MIT License
166 stars 37 forks source link

[Blue Burst] Battle Mode scores aren't being updated correctly and scores are being lost after relogin #316

Closed nolrinale closed 4 months ago

nolrinale commented 10 months ago

Created a room with Battle Mode Rule 5 and rule 6 with 4 players noticed in both some of the parameters such as taken/received damage arent recorded properly either it always displays a 0 Screenshot from 2024-01-04 00-45-12

Screenshot from 2024-01-04 00-45-26

Screenshot from 2024-01-04 00-49-29

The log is very long and includes the session starting the server, logging on the 4 clients, then starting 3 battle modes 2 sessions of Battle 6 and 1 session of Battle 5 4PLAYERBattleModeDMGandSCOREChecks.txt

fuzziqersoftware commented 9 months ago

This may have been fixed by 0de3d273. Could you try again?

nolrinale commented 9 months ago

Tested with Battle Rule 7 and Battle Rule 4 BattleRule7and4WrongScores.txt

In the log search for Game:15 for Rule 7 and Game:16 for the Rule 4

Attached Screnies of Rule 4

It is a meseta battle, the winner with most meseta wins, however in the final results I think it's saving total damage rather than total meseta, and the 2nd page which is meant to display total damages still displays 0 for all fields

Screenshot from 2024-01-25 17-30-30 Screenshot from 2024-01-25 17-30-15

Attached Screenies of Rule 7

This one is a meseta battle but nothing in this map drops meseta, rather the kills are counted as meseta (will verify on PSOGC later) still the results look a little bit odd to me in both pages.

Screenshot from 2024-01-25 17-17-36 Screenshot from 2024-01-25 17-17-29

nolrinale commented 9 months ago

In the case of Battle Rule 5 player 1 got dced for breaking a box but the match was able to still end and in this case the mesetas were correctly counted for the main game, but the damages fields in 2nd page are all still 0 for everyone

Heres the log with just this session and screenies BattleRule5WrongScoreCheck2.txt

Screenshot from 2024-01-25 17-49-37

Screenshot from 2024-01-25 17-49-28

nolrinale commented 9 months ago

Lastly, heres the full log of a full Battle Rule 6 session, I dont understand why the scores are always in negative and the damages seem different but a little bit odd still with such low numbers, in this case the party used a mixture of unarmed attacks, attacks with weapons, attack with techs.

This log also includes returning to the lobby were the F12 stats menu displays the current score but the W: and D: fields by pressing TAB still shows 0 for everyone regardless BattleRule6Check2ndAndLobbyStats.txt

Screenshot from 2024-01-25 18-07-11 Screenshot from 2024-01-25 18-07-22 Screenshot from 2024-01-25 18-08-17 Screenshot from 2024-01-25 18-07-53

nolrinale commented 8 months ago

@fuzziqersoftware tested it again in battle rule 4 in temple and I ended up first place with 150ish meseta, is not counted right at the end, an the damage counters are still all at 0 despite punching and using techs against eachother characters.

image image

Restarted the game with the same Rules and Player 2 rage quit on purpose, upon returning to lobby the disconnect counter remains at 0 and the 1st place counter also remains at 0 (this player had won the previous match in 1st place regardless)

image

The whole session including rage quitting at the end

BattleRule4Session3rdCheck.txt

nolrinale commented 5 months ago

Tested with the latest build it seems to be the Damage Receive/Give counters arent still working after every match (the 2nd page) displays them as 0 or very low numbers (despite battling both characters with plenty of damage with and without weapons)

This time I tested with Battle Rule 07

And once the match finished in the Lobby the scores arent getting updated in the W: D: texts above the players heads image

If you restart the server, the battle scores are also completely lost too, with all the counters going back to 0 image

fuzziqersoftware commented 4 months ago

This has been fixed; battle mode results now save properly. I was unable to find any remaining problems with the in-battle score display.