Adjusted quest filtering for Cmode and Gov Quests

fuzziqersoftware / newserv

Phantasy Star Online game server, proxy, and reverse-engineering tools

MIT License

159 stars 35 forks source link

Adjusted quest filtering for Cmode and Gov Quests #513

Closed nolrinale closed 3 months ago

nolrinale commented 3 months ago

This little PR adjusts the filtering behavior so the Government and Challenge Mode quests are displayed only in their correct Episodes to match the correct retail server spec.

Challenge Mode Episode 1 quests in Episode 1 Cmode Room
Challenge Mode Episode 2 quests in Episode 2 Cmode Room
Government Quests Episode 1 in Episode 1 Normal Room
Government Quests Episode 2 in Episode 2 Normal Room
Government Quests Episode 4 in Episode 4 Normal Room

fuzziqersoftware commented 3 months ago

This should not be the default behavior. The only reason the default quest categories have this flag set is because there are too many quests in some categories to show them all at the counter if we didn't filter by episode. In battle, challenge, and government categories, this will never be the case, so it's more convenient for players to allow them to choose quests from other episodes. I'm pretty sure we've discussed this in the past, but I'm not going to spend time digging it up.