Missing "address-of" operator & in arm_reg_ptr function.

fuzzware-fuzzer / fuzzware

Fuzzware's main repository. Start here to install.

Apache License 2.0

302 stars 51 forks source link

Missing "address-of" operator & in arm_reg_ptr function. #38

Open enlighten5 opened 8 months ago

enlighten5 commented 8 months ago

It looks to me that the arm_reg_ptr function is getting the reference of arm registers, but the reference operator & is missing when handling registers from R0 to R12 and D0 to D31, as shown in this fix.

Please let me know if this makes sense.

Regards.

Scepticz commented 8 months ago

Hi enlighten5,

that makes sense. I think this was due to the fact that the API is used for the NVIC implementation which does not use the general purpose registers. If you like, you could create a pull request.

Tobi

enlighten5 commented 8 months ago

Sure, I've created a pull request.

Also, I am wondering if you plan to upgrade the unicorn emulator to the latest version.

I tried to port your changes to Unicorn to the latest version. but there are some crashes when running with the pipeline. I haven't looked into it yet but I guess it might be related to incompatibilities with the code in fuzzware_harness.