fuzzysb / Tado

Tado (Connect) SmartThings Integration Repo
Apache License 2.0
31 stars 127 forks source link

Tado Thermostats not setting supportedThermostatModes #8

Open andrewsayre opened 5 years ago

andrewsayre commented 5 years ago

Tado (Connect) thermostats (cooling and heating) are not fully implementing the required attributes of the Thermostat Mode capability. Specifically, they are not setting supportedThermostatModes which is a required attribute. This causes problem in third party integrations with SmartThings that expect this value to be populated, such as seen in home-assistant/home-assistant#21298

fuzzysb commented 5 years ago

@andrewsayre This project is now discontinued, i no longer have access to the smartthings platform which is undertaking a large amount of change ( it used to conform to the Thermostat Specification, but this is being modified by samsung) . please create a pull request with the required changes and i will merge

andrewsayre commented 5 years ago

This project is now discontinued, i no longer have access to the smartthings platform which is undertaking a large amount of change ( it used to conform to the Thermostat Specification, but this is being modified by samsung) . please create a pull request with the required changes and i will merge

FYI @rafuz Are you able to resolve and submit a PR? I don't have these devices to know the logic of which modes are supported, but can try and sketch something together over the weekend if need be.

rafuz commented 5 years ago

I have the devices, smartthing v2 hub and home assistant so I am able to test the full enviroment. Anyway I am not much able to correct the DHT alone and I am also trying to fix the native HomeAssistant Tado AC integration https://community.home-assistant.io/t/tado-ac-how-to-properly-configure/58478/3

fuzzysb commented 5 years ago

@rafuz if you need any help I have a much improved plugin for Homeseer and have a lot more of the functionality fixed in that plugin. And it uses oauth