search

fvarrui / JavaPackager

:package: Gradle/Maven plugin to package Java applications as native Windows, MacOS, or Linux executables and create installers for them.
GNU General Public License v3.0
1.07k stars 134 forks source link

Always build sources #236

Closed kerner1000 closed 2 years ago

fvarrui commented 2 years ago

I'm not really sure about this change ... please, can you explain me what it does? 😅 Thanks!

kerner1000 commented 2 years ago

Hi @fvarrui , I usually don't use Gradle, so this is maybe not how it's supposed to be but for me this change did was I was excepting 🙈. The Idea of this PR is to include the generation of a sources jar also in non-release builds. That is important when you are developing on the plugin so your IDE can attach the current sources and you can debug out of the other project that you are developing and which is using this Maven/ Gradle plugin.

fvarrui commented 2 years ago

Great! You convinced me 😄 ... It makes sense