search

fvarrui / JavaPackager

:package: Gradle/Maven plugin to package Java applications as native Windows, MacOS, or Linux executables and create installers for them.
GNU General Public License v3.0
1.07k stars 134 forks source link

Code-signing for macOS does not sign JRE jars #285

Closed kerner1000 closed 1 year ago

kerner1000 commented 1 year ago

Already working on it.

fvarrui commented 1 year ago

Hi @kerner1000! Could you provide a detailed description about this issue, please?

kerner1000 commented 1 year ago

When I test an .app file, that has been bundled using JavaPackager with codesign --verify, it complains that a jar file within the JRE path is not codesigned at all.

Don't know exactly why this is like that, I am still debugging.

fvarrui commented 1 year ago

Hey! What happened with your PR relateed to this issue?

kerner1000 commented 1 year ago

I cannot reliably say what the problem is, so I cannot provide Andy PR :( I use jackage now to code sign the app. It also packages it. It works well. I wrote a small maven plugin to do the task.