search

fvarrui / JavaPackager

:package: Gradle/Maven plugin to package Java applications as native Windows, MacOS, or Linux executables and create installers for them.
GNU General Public License v3.0
1.07k stars 133 forks source link

Minor change to the Windows Properties documentation #319

Closed EasyG0ing1 closed 1 year ago

EasyG0ing1 commented 1 year ago

I submitted this in a PR before, but I think you committed it to the DEVEL branch and it needs to be committed to the main branch so that it becomes part of the public-facing documentation.

The issue is that in the markdown file under the docs folder with the name:

windows-specific-properties.md

The listed options for header type shows gui as being the only option. However, both gui and console are valid options for that setting, so the line in the document should look like this:

<headerType>gui|console</headerType>

This needs to be merged into the main branch so that the change is visible in the public-facing documentation here in the repository.

fvarrui commented 1 year ago

Thanks! Changes already applied into master branch