search

fvarrui / JavaPackager

:package: Gradle/Maven plugin to package Java applications as native Windows, MacOS, or Linux executables and create installers for them.
GNU General Public License v3.0
1.07k stars 134 forks source link

AppStream upstream metadata is missing #344

Open SaptarshiSarkar12 opened 1 year ago

SaptarshiSarkar12 commented 1 year ago

I'm submitting a…

Short description of the issue/suggestion: When the Drifty application is packaged using JavaPackager Maven plugin via GitHub Action, it shows the below error 👇

WARNING: AppStream upstream metadata is missing, please consider creating it

How can I fix it?

Do you have outputs, screenshots, demos or samples which demonstrate the problem or enhancement? You can check the GitHub Action output to see the error.

Please tell us about your environment:

Other Information You can check the pom.xml file to see if any changes needs to be made in that.

SaptarshiSarkar12 commented 1 year ago

@fvarrui Please look into the issue.

fvarrui commented 1 year ago

Hi @SaptarshiSarkar12!

I fear you can fix it ... unless you code a patch for JavaPackager and make a PR.

I'll take a look into it ASAP.

Anyway, it's showing a warning message, not an error. Have you tried to run the generated AppImage?

SaptarshiSarkar12 commented 1 year ago

Hi @SaptarshiSarkar12!

I fear you can fix it ... unless you code a patch for JavaPackager and make a PR.

I'll take a look into it ASAP.

Anyway, it's showing a warning message, not an error. Have you tried to run the generated AppImage?

@fvarrui Yes, the AppImage runs pretty well.

SaptarshiSarkar12 commented 1 year ago

Thank you for giving your valuable time to resolve the issue!

SaptarshiSarkar12 commented 1 year ago

@fvarrui Please check this docs of freedesktop about metadata file. It says to create a app_name.metadata.xml file in /usr/share/metainfo/ directory before building the AppImage. I think this file can be auto-created by JavaPackager before initiating the building of AppImages. So, it might be a good feature we should bring in this project. @fvarrui Let me know your opinion.

fvarrui commented 1 year ago

@SaptarshiSarkar12 Ok, I've just check this example and it seems that all required data is available in JP. As it's related to issue-345, and there's already a branch for this issue, changes will be made in this branch.

As far as I understand, this is not only for AppImage, but DEB and RPM too, right?

SaptarshiSarkar12 commented 1 year ago

@SaptarshiSarkar12 Ok, I've just check this example and it seems that all required data is available in JP. As it's related to issue-345, and there's already a branch for this issue, changes will be made in this branch.

As far as I understand, this is not only for AppImage, but DEB and RPM too, right?

Ok @fvarrui, that's great! No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager. Below are the required relevant screenshots and links :

Deb package in Software Install

Link to pom.xml : https://github.com/SaptarshiSarkar12/Drifty/blob/master/pom.xml

fvarrui commented 1 year ago

No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager.

So, do you mean that metadata file has also to be provided by DEB and RPM packages?

SaptarshiSarkar12 commented 1 year ago

No, there is some problems regarding DEB and might be RPM also. The problem is that the description shown by Software Install application in ubuntu (when trying to install DEB package) is not as what is provided to JavaPackager.

So, do you mean that metadata file has also to be provided by DEB and RPM packages?

Yeah @fvarrui, it might help. Also, the application icon is not present when opening DEB (might be the same case with RPM) through Software Install application in Ubuntu 23.04.