fvarrui / JavaPackager

:package: Gradle/Maven plugin to package Java applications as native Windows, MacOS, or Linux executables and create installers for them.
GNU General Public License v3.0
1.07k stars 133 forks source link

Update jsign to 4.1+ #351

Closed commi closed 1 year ago

commi commented 1 year ago

I'm submitting a…

We'd like to use jsign with SSL.com's eSigner, and jsign supports this from version 4.1 on (https://github.com/ebourg/jsign/releases/tag/4.1). I saw that the relevant params are already passed to jsign unaltered (except for storetype=PKCS11).

What is the motivation / use case for changing the behavior?

MS Authenticode requires USB-Tokens for Key-Storage from now on. An alternative is string the Key at a external Service that allows access to the signing process via API. SSL.com offers an API that jsign supports.

Other information (e.g. related issues, suggestions how to fix, links for us to have context)

The API of jsign might have changed since the versin curently used... if this is more than a simple change in the pom.xml then i'll work on a pull request.

fvarrui commented 1 year ago

Hi @commi! I've just upgraded jsign to 5.0 and publish a snapshort version: 1.7.4-20230811.145854-1. Please, try it and give me some feedback. Thanks!!

commi commented 1 year ago

Tested and works!

fvarrui commented 1 year ago

Branch issue-351 merged into devel, ready to me released in v1.7.4

fvarrui commented 1 year ago

1.7.4 released to Maven Central