search

fvarrui / JavaPackager

:package: Gradle/Maven plugin to package Java applications as native Windows, MacOS, or Linux executables and create installers for them.
GNU General Public License v3.0
1.07k stars 133 forks source link

Why rename the .jar? #390

Closed ryanhamilton closed 4 months ago

ryanhamilton commented 10 months ago

Hi, Your tool is working great. Thanks.

One question, for linux why do you rename the .jar?

I'm asking as:

  1. Keeping it .jar in theory makes it still easily runnable for a windows user that downloads the wrong package.
  2. Keeping it .jar, would make it clear to the linux user that it's a java file.

I don't see the benefit to changing the name?

I even tried setting runnableJar = file("app.jar.jar") but it removed both the .jars :)

fvarrui commented 9 months ago

Hi @ryanhamilton! Some files are renamed with the generic name "app.*" because some tools (like launch4j) don't support filenames with CHK characters ... maybe this not happens on Linux, but it was implemented as a generic behaviour

fvarrui commented 9 months ago

Hi, Your tool is working great. Thanks.

You are welcome 😄

fvarrui commented 4 months ago

I'm closing this issue due to lack of activity. Feel free to reopen it if you need more info