search

fvdm / nodejs-vnstat-dumpdb

Node.js wrapper for vnStat --dumpdb, with error handling and the same output structure on each system
https://www.npmjs.com/package/vnstat-dumpdb
The Unlicense
6 stars 8 forks source link

[Bug]Preinstall fails when vnstat version has higher major but lower Minor (like 2.6) #11

Open yajouahr opened 3 years ago

yajouahr commented 3 years ago

in preinstall script, your check if version is higher or equal to 1.13 fails for version 2.6 for example.

if( major === 1 && minor >= 13 || major > 1) return;

should work better. I had to dowgrade my vnstat version so that it works.

fvdm commented 3 years ago

@yajouahr Thanks! The code of this pkg looks super old. I'm rewriting it today.

7c commented 3 years ago

have you updated the npm? So we can do an update please?