search

fveronesi / NOAA_ShinyApp

8 stars 3 forks source link

Consider adding to GSODR? #1

Open adamhsparks opened 5 years ago

adamhsparks commented 5 years ago

I tried to leave a comment on your blog post, not sure if I was successful or not.

Would you consider adding your Shiny app's capability to GSODR, https://ropensci.github.io/GSODR/?

I'm wondering if much of the codebase could not be useful for mapping the data in ISD-history for selecting stations to download?

Nonetheless, it would still be useful for the purposes you've described where the files have been batch downloaded for several years and then selecting files locally for an area of interest. This is something we've kicked around for bomrang, https://ropensci.github.io/bomrang/, as well, but haven't implemented yet.

fabioveronesi commented 5 years ago

Yes, we can try. How do you want to proceed?

fveronesi commented 5 years ago

Sorry, I commented with the wrong account

adamhsparks commented 5 years ago

Sorry, was away on travel for a few days.

I'll fork GSODR to my personal account from the rOpenSci repository and see what I can do to incorporate some of the basic functionality and give you access to it and we can work on it from there.

adamhsparks commented 5 years ago

I'm working on a new release finally. I've sent you an invite to my personal repository forked from ROpenSci. I have not done anything yet to incorporate your Shiny app. I hope to get started on it this week though.

I'll be working on the devel branch when I do get to this.

adamhsparks commented 4 years ago

I'm a year late, but I'm getting to this! I've invited you as a collaborator on this project, https://github.com/adamhsparks/easyGSODR.

My idea is to build on what you've done for local files since GSODR can parse local files, but also to simplify selecting files from the map and using GSODR to download them after selection. I decided on a separate package to keep the GSODR dependencies slimmer than they would be with this. It also gives us more flexibility to work with this.

Feel free to contribute as you wish and are able to.