search

fviard / sllurp

Python client for LLRP-based RFID readers. Private fork.
GNU General Public License v3.0
7 stars 3 forks source link

Llrp keepalive support #15

Closed HanYangZhao closed 4 years ago

fviard commented 4 years ago

Almost good. Would you be ok to rename: "reader_keepalive_interval" simply to "keepalive_interval" ? I think that it is kind of redondant to use the word "reader" when we are already in reader config?

Btw, you can also put its definition before the impinj specific one, as it is a common config.

Thanks

HanYangZhao commented 4 years ago

Sure no problem

fviard commented 4 years ago

Merged, thanks :-)