Missing some parantheses / apostrophes in Line 4628 of llrp_proto.py

fviard / sllurp

Python client for LLRP-based RFID readers. Private fork.

GNU General Public License v3.0

7 stars 3 forks source link

Missing some parantheses / apostrophes in Line 4628 of llrp_proto.py #20

Closed jtabb16 closed 10 months ago

jtabb16 commented 3 years ago

Thank you for your work. I'm using this code to help me understand LLRP with the Zebra FX 7500.

Line 4628 in llrpproto.py says: par, = decode_all_parameters(data[ubyte_size:], MotoFilterRule, par)

This throws an error when you run the sllurp gui because when this line of code runs, Python thinks MotoFilterRule is a variable. MotoFilterRule should be 'MotoFilterRule', just as all the other commands have apostrophes around them.

fviard commented 3 years ago

Hi, indeed you are right and it's a good catch. Would you like to do me pull request with the fix?

Don't hesitate to report if you find other issues when using sllurp to use your Zebra reader as I don't have one to test.

fviard commented 10 months ago

Closing as fixed.