search

fvictorio / completely

Generate shell completion scripts from a JSON description of a command.
28 stars 2 forks source link

Fix bash template to add command completion for flags #2

Closed francislavoie closed 4 years ago

francislavoie commented 4 years ago

We're using this for https://caddyserver.com to set up some bash/zsh completions.

See here: https://github.com/caddyserver/dist/tree/master/scripts/completions

We noticed the command type didn't work for --flags. Did some digging, it was just missing the bit in the template to handle it :+1:

BTW it looks like for zsh, command was never implemented? Also we're having trouble with zsh positional args, the template doesn't seem to do anything with those.

/cc @Mohammed90

fvictorio commented 4 years ago

Hi @francislavoie! Glad you found this project useful. Sorry for taking some days to review your PR, but I haven't worked on this for a few months now and I needed to remember how it all worked. But I do want to keep it alive, so I'm going to open some issues for the things you mentioned and see if I can work of them. Of course, any other contribution or suggestion is welcome!

francislavoie commented 4 years ago

Thanks!

fvictorio commented 4 years ago

Just published a new version with this change.