Upgrade prettier to latest version

fvictorio / solhint-plugin-prettier

A Solhint plugin for checking your contracts style

28 stars 13 forks source link

Upgrade prettier to latest version #12

Closed alyavasilyeva closed 10 months ago

alyavasilyeva commented 1 year ago

What issue this PR solves:

Current version of solhint-plugin-prettier with Prettier v3 throws TypeError: this.prettier.resolveConfig.sync is not a function. This happens because in Prettier v3 prettier.resolveConfig.sync has been removed.

What I did to fix it:

upgrade prettier to v3;
replace prettier.format() and prettier.resolveConfig.sync() with now asynchronous prettier.format() and prettier.resolveConfig();
make SourceUnit method asynchronous

maxhiker commented 1 year ago

@fvictorio please consider to merge it, it works well (at least for me) with latest as of today "prettier": "^3.0.1", "prettier-plugin-solidity": "^1.1.3",

ovasylenko commented 12 months ago

Any updates when it will be merged?

martelskiy commented 10 months ago

any updates on this? It would be good to merge it though, we cannot keep our dependencies up to date due to the older prettier version plugin requires

fvictorio commented 10 months ago

Closing in favor of https://github.com/fvictorio/solhint-plugin-prettier/pull/17

This PR assumes that the SourceUnit visitor can be async, but that's not the case.