Closed alyavasilyeva closed 10 months ago
@fvictorio please consider to merge it, it works well (at least for me) with latest as of today "prettier": "^3.0.1", "prettier-plugin-solidity": "^1.1.3",
Any updates when it will be merged?
any updates on this? It would be good to merge it though, we cannot keep our dependencies up to date due to the older prettier version plugin requires
Closing in favor of https://github.com/fvictorio/solhint-plugin-prettier/pull/17
This PR assumes that the SourceUnit
visitor can be async, but that's not the case.
What issue this PR solves:
Current version of
solhint-plugin-prettier
with Prettier v3 throwsTypeError: this.prettier.resolveConfig.sync is not a function
. This happens because in Prettier v3prettier.resolveConfig.sync
has been removed.What I did to fix it:
prettier.format()
andprettier.resolveConfig.sync()
with now asynchronousprettier.format()
andprettier.resolveConfig()
;SourceUnit
method asynchronous