search

fvictorio / solhint-plugin-prettier

A Solhint plugin for checking your contracts style
28 stars 13 forks source link

Why "prettier/prettier": "error"? #3

Closed PaulRBerg closed 4 years ago

PaulRBerg commented 4 years ago

Great plugin! Just what I was looking for to start using solhint and prettier-plugin-solidity together.

The README indicates that we should set the "prettier" rule to "error", but gives no explanation for why we should do that.

fvictorio commented 4 years ago

Ok, apparently my user automatically stopped watching this repo (as many others, wtf github??). So sorry for not answering before!

You can use "warning" instead of "error", that's just fine. Do you think it would make more sense for the readme to have that as a default?

I don't really have a strong opinion here. For me, an error is something that stops you from committing, and forgetting to run prettier seems like something you'd want to know. That's the only reason. But, again, either level seems fine to me :slightly_smiling_face:

PaulRBerg commented 4 years ago

No worries!

You can use "warning" instead of "error", that's just fine. Do you think it would make more sense for the readme to have that as a default?

Perhaps? What I was alluding to is more of like explaining the rationale behind doing this.

fvictorio commented 4 years ago

Forgot to close this. Thanks again Paul!