search

fvisin / dataset_loaders

A collection of dataset loaders
GNU General Public License v3.0
195 stars 63 forks source link

[WIP] Cortical layers #4

Closed lamblin closed 7 years ago

lamblin commented 7 years ago

This is @adri-romsor's loader for a 1D dataset for segmentation of cortical layers. I'm wondering if it would make sense to include it here, and what would be needed for inclusion.

lamblin commented 7 years ago

Actually, most of the changes to __init__.py should probably go in a separate PR.

fvisin commented 7 years ago

Thanks for the PR. I begun looking into it (sorry in advance, I don't have much time in the next weeks but I'll try my best to do it in a reasonable amount of time) and it looks like there is a lot of duplicated code.

What are the main differences introduced by parallel_loader_1D? Do you think it would be possible to modify parallel_loader.py directly, e.g., by checking self.data_shape to detect the 1D case? If not, is there a way to reuse the code from parallel_loader.py, e.g., by splitting the existing methods in more fine-grained submethods that can be overridden by the 1D class?

Actually, most of the changes to __init__.py should probably go in a separate PR.

It should indeed, but we can be not too formal on that, for this once. ;) Thanks for those changes BTW, a nice improvement over what I wrote!

lamblin commented 7 years ago

Replaced by #5.

lamblin commented 7 years ago

And the changes in __init__.py are in #6.