Johannes can't apply patches on Windows using GnuWin32 patch.exe

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Check out johannes (I used r3227)
2. Set up build environment. I used patch.exe from the GnuWin32 difftools
package, which I added to the PATH
3. python johannes.py -w ...

What is the expected output? What do you see instead?
Some way into the build process, patch.exe crashes with an assertion
failure. This is a known limitation of this version (see
http://gnuwin32.sourceforge.net/packages/patch.htm), and is due to the fact
that the GnuWin32 port expects CRLF line endings. The DeVIDE patch files in
the VTK package use LF line endings.

The attached patch uses the unix2dos utility (also from GnuWin32) to
convert the patch files after downloading. It might be better to centralize
this a bit, and determine if the patch utility actually needs this rather
than relying on the os.name.

Original issue reported on code.google.com by stef.bus...@gmail.com on 1 Sep 2008 at 3:16

Attachments:

• johannes-gnuwin-patch.diff

[GoogleCodeExporter]

Have since fixed this by making sure that all patches have the svn:eol-style 
property 
set to native.  I have since also performed full builds on win32 and win64 with 
gnuwin32 patch.

Original comment by cpbotha on 11 Aug 2009 at 3:04

• Changed state: Fixed