search

fvsch / kirby-twig

Twig templating support for Kirby CMS 2. For Kirby 3, use https://github.com/amteich/kirby-twig
MIT License
70 stars 8 forks source link

Can't register namespaces, functions & filters in plugins #25

Closed kraftner closed 6 years ago

kraftner commented 6 years ago

It seems as if using $kirby->options has the downside that anything you set outside/after config.php is being ignored. That is kind of sad because unless I got something really wrong you can't add anything from plugins now in contrast to what the docs say.

I'm pretty new to kirby, but I think that one would need to use c::$data and c::get() to make this work.

Let me know if you need any more infos on this.

fvsch commented 6 years ago

Good catch. This should be fixed in 3.0.1: https://github.com/fvsch/kirby-twig/commit/c755d8b33bc4ee867a2230fa9596ce0114166625

Can you test on your side? (Both the classic and Composer install methods should work.)

kraftner commented 6 years ago

Wow, that was fast! :heart_eyes: Everything working as expected. Merci beaucoup!