fvsch / kirby-twig

Twig templating support for Kirby CMS 2. For Kirby 3, use https://github.com/amteich/kirby-twig
MIT License
70 stars 8 forks source link

Working Kirby 3 Version. #33

Closed seehat closed 6 years ago

fvsch commented 6 years ago

Hi @seehat. Sorry for not replying earlier.

I’ve only been following Kirby3 dev from a distance and I don’t think I’m going to use it soon. Currently focused on other open-source contributions. :)

So I was wondering if you wanted to maintain your fork separately? This would imply:

  1. Using a different namespace (seehat\KirbyTwig maybe)
  2. An opportunity to drop features or options that might not be useful
  3. You could even restart the git history from your current working version, if you don’t want to keep the noise of this project and the Twig lib’s sources being vendored in, updated and removed.

I’d be perfectly happy with passing the baton to you (keeping this repo only for Kirby 2 users), if you’re interested, and maybe contributing bug reports and PRs if I end up using Kirby 3 in a few months.

The composer.json’s authors could look like:

"authors": [
    {
        "name": "Christian Zehetner",
        "email": "<your_email>"
    },
    {
        "name": "Florens Verschelde",
        "email": "florens@fvsch.com"
    }
],

:)

But maybe this is much more than you’ve bargained for. :D

seehat commented 6 years ago

Hi @fvsch, sry for being late too.

Thank you for your offer. I am pleased to maintain the Kirby 3 fork separately and will make your proposed changes to the codebase. ;)