fvtt-fria-ligan / blade-runner-foundry-vtt

Official Blade Runner RPG game System for the Foundry Virtual Table Top. Made by @Stefouch.
https://foundryvtt.com/packages/blade-runner
Other
4 stars 6 forks source link

Incorrect handling of maneuverability when actor placed in vehicle by another player #32

Open Lim-Dul opened 1 year ago

Lim-Dul commented 1 year ago

Describe the bug

Actual Result When an actor is placed in a vehicle by another player the maneuverability stat on the character sheet doesn't update (appropriate Blade Runner system settings are checked) without GM permissions. The stat is being updated properly if the player places the actor in a vehicle themselves or if they have GM permissions.

Expected Result The maneuverability stat is properly applied to an actor for any player when placed in a vehicle by any other player or themselves.

Notes

Reproduction

Prerequisites

Steps to Reproduce

  1. Have GM player drag in character actor onto the driver slot of vehicle actor
  2. Have Trusted Player click on the crewed character actor to carry out a maneuverability check (it will only display the option to roll with disadvantage as the maneuverability was not updated)
  3. Have Trusted Player uncrew the character actor
  4. Have Trusted Player crew the character actor
  5. Have Trusted Player and GM click on the character actor to carry out a maneuverability check (both will display roll options including proper vehicle maneuverability rating)

Notes See following recording of the issue: https://streamable.com/tuw0dm

System Info

Windows 11 Pro 22H2 (Build 22621.2283)
Chrome 116.0.5845.188 / Firefox 117.0.1
FoundryVTT Version 11 Build 309

Logs

No response

Priority this issue should have?

Medium (minor functional impact)

Validations

Stefouch commented 3 months ago

Hi @Lim-Dul , Sorry if this issue has not been fixed yet. It's a tricky one since it's messing with Foundry's permissions system. I still has not figured to fix this issue yet.

Lim-Dul commented 3 months ago

Fret not, we've been managing in the meantime. Still playing a campaign in BR. ;) I will have a new bug to report though regarding V12 compatibility. More work!