search

fvtt-fria-ligan / forbidden-lands-foundry-vtt

This is a Forbidden Lands game System for the Foundry Virtual Tabletop. Made by @Perfectro, @patrys and @aMediocreDad. Maintained by @aMediocreDad
https://foundryvtt.com/packages/forbidden-lands/
Other
40 stars 43 forks source link

Add references to the Item on all rolls #229

Closed TheGiantRat65 closed 2 years ago

TheGiantRat65 commented 2 years ago

Is your feature request related to a problem? Please describe. Currently when trying to use the Automated Animations module for monster attacks it doesn't work.

Describe the solution you'd like I would like to be able to tie animations to monster attacks.

Describe alternatives you've considered Making them as normal character sheets and using them that way, this works fine, it's just a bit impractical.

Additional context I'm aware that in a lot of cases the attacks mention who they are going to target and as a result it wouldn't be fully automatic (i would have to select the attack after rolling to see which one) but I'm ok with that.

I asked in the Automated Animations discord (JB2A discord) and @Otigon said this:

"Like * showed above, there is no reference to the Item when using a Monster Attack. This will cause A-A to exit early as it cannot find the item.

I'm getting the Item data in a non-optimal way as it is with Forbidden Lands using the _roll field. If you log a request on the System GitHub to add references to the Item on all rolls in Forbidden Lands, I could fix it if they are able to add it in. A-A needs either the Item, Item-ID or Item UUID to get what it needs"

I have no idea what most of that means so I've sent the full chat log.

Thanks for any help, and sorry if this is a very hard fix (I have no idea).

otigon commented 2 years ago

A-A is currently able to grab the ItemId from the createChatMessage hook inside the _roll object. It seems this data is not present when using Monster Attacks.

If this could be standardized in the System to give reference to the Item being used no matter the source (via Item, ItemId or Item UUID) this could benefit other modules as well.

narukaioh commented 2 years ago

I did the integration implementation with this module. With the paid module you can configure attacks and animations

otigon commented 2 years ago

@narukaioh do you mean the Patreon JB2A or is there a premium version of FBL?

TheGiantRat65 commented 2 years ago

I have both of them and I am unable to use them for the monsters still, am I missing something?