Improper implementation of Pushing

EmptyOwl01 commented 1 year ago

Describe the bug

I notice that pushing is not quite correct in the T2k4e implementation as well, since you can (technically) reroll base dice with successes and this is not allowed in the Foundry ruleset.

Reproduction

Roll some dice, get at least a success on one or both dice, Push the roll (if you even can).

System Info

windows

Logs

No response

Priority this issue should have?

Medium (minor functional impact)

Validations

[X] Done a clean install of the system.
[X] Disabled all modules.
[X] Checked if the issue is present in a new world instance (create a new world in foundry using the Twilight 2000 system).

Stefouch commented 5 months ago

Roll mechanics have been updated since then. It should be good.

Stefouch commented 4 months ago

Reopened as there was a confusion and I think this issue has not been resolved yet.

Fortunately, the Blade Runner RPG has already implemented the ability to reroll specific dice here: https://github.com/fvtt-fria-ligan/blade-runner-foundry-vtt/blob/8b55097c9be73fdc100cc82b3e5de95f32f42b89/src/components/roll/roller.js#L433 This might help.

fvtt-fria-ligan / twilight2000-foundry-vtt