fvutils / pyvsc

Python packages providing a library for Verification Stimulus and Coverage
https://fvutils.github.io/pyvsc
Apache License 2.0
113 stars 26 forks source link

Support for randcase #42

Closed ishitapvips closed 3 years ago

ishitapvips commented 4 years ago

Hi,

System Verilog has a rand case property, that specifies the probability of any case statement to be selected. We tried some workaround but haven't found the solution. So, can we have support for the same in pyvsc or some other way to do it?

Thanks & Regards, Ishita

mballance commented 4 years ago

Hi @ishitapvips, This is an interesting question, given that Python doesn't have a builtin case statement. I could see a couple of approaches. Perhaps you can provide feedback on which would fit best in your application. Fundamentally, rand-case is the combination of weighted selection and a case statement. We could model this in Python with a weighted selection from a collection of values that represent the case options. Let's say we're replacing a rand-case statement like the following:

randcase
    3 : x = 1;
    1 : x = 2;
    4 : x = 3;
endcase

This approach would look something like:

branch = vsc.select({ 1 : 3, 2 : 1, 3 : 4})
if branch == 1:
  x = 1
elif branch == 2:
  x = 2
elif branch == 3:
  x = 3

In other words, we specify a map with the key being the branch and the value being the branch weight. select returns the selected branch, and we use a regular if/else statement.

Another approach would be to use lambda expressions. Lambda expressions are pretty limited in Python, so you would likely need to put the actual implementation of the case branches in separate functions. That might look like this:

vsc.randcase([
  [3, lambda : do_branch1()],
  [1, lambda : do_branch2()],
  [4, lambda : do_branch3()]
  ])

So, a couple approaches to doing this in Python with PyVSC. Any thoughts on which approach would work best for your application?

Thanks and Best Regards, Matthew

ishita71 commented 4 years ago

Hi Matthew,

As per your convenience, any of the approaches will work for us. But lambda function would be straight forward so can you implement that one?

Thanks & Regards, Ishita

mballance commented 4 years ago

Hi Ishita, I've added support for a 'randselect' method that performs a weighted selection between a list of lambda functions. Here's an example: https://github.com/fvutils/pyvsc/blob/487620ad2ccca6c2327731f20c2665a823971656/ve/unit/test_select.py#L22-L36

I'll leave this issue open until you're able to confirm that it works for you.

Best Regards, Matthew

ishita71 commented 4 years ago

Hi Matthew,

Randselect is working fine for me right now. If any issue is found later will comment here.

Thanks & Regards, Ishita Shah