search

fvwmorg / fvwm3

FVWM version 3 -- the successor to fvwm2
Other
511 stars 78 forks source link

UseSkipList doesn't work #1000

Closed rasatpc closed 5 months ago

rasatpc commented 5 months ago

*FvwmPager: UseSkipList

Does not hide modules and windows that are using the WindowListSkip style.

ThomasAdam commented 5 months ago

@somiaj -- I think this is due to commit fbfedabcb85bd0b6e6978c6d7e035afcc8dd7d19 -- any chance that logic could be reintroduced?

@rasatpc -- how are you building fvwm3? 1.1.1 is not a release of fvwm3, so I'm guessing you must be building from a .zip archive or something? Not sure why you'd do that...

somiaj commented 5 months ago

I'll take a look at it, I'll see what I missed and figure out how to correctly filter out the windows on the skip list.

rasatpc commented 5 months ago

how are you building fvwm3?

I am not using a fork or git clone but downloading from Fvwm3 GitHub website. Green button "<> Code" Download ZIP.

somiaj commented 5 months ago

@rasatpc just git clone, and build from the git source, that zip method isn't really a nice way to go about things. This will also help you learn git more.

somiaj commented 5 months ago

@rasatpc, see if #1001 fixes the issue for you.

rasatpc commented 5 months ago

that zip method isn't really a nice way to go about things.

I will not change the method. I am doing the test as per how common Fvwm users will do. This is how I find bugs that go unnoticed by the developers.

see if #1001 fixes the issue for you.

Thanks, it works fine.