search

fvwmorg / fvwm3

FVWM version 3 -- the successor to fvwm2
Other
507 stars 79 forks source link

reserved identifier violation #104

Closed elfring closed 1 year ago

elfring commented 4 years ago

I would like to point out that identifiers like “_EWMH_” and “_MENUS_” do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

ThomasAdam commented 4 years ago

Hi @elfring,

Indeed, you're correct. This is from circa 2001.

As always, patches welcome. Bonus points from your kind self, if you use coccinelle to do it.

Always happy to be increasing the cocci scripts in contrib/coccinelle...

Thanks, Thomas

elfring commented 1 year ago

:thought_balloon: How do you think about to avoid that this software depends on undefined behaviour?