fvwmorg / fvwm3

FVWM version 3 -- the successor to fvwm2
Other
505 stars 79 forks source link

Desk 0 not accessible. #957

Closed rasatpc closed 6 months ago

rasatpc commented 6 months ago

Upfront Information

Expected Behaviour

What were you trying to do? Please explain the problem.

Ivar on Fvwm forum, upgraded to 1.1.0 and he cannot access Desk 0 in the pager with 4 desks. Left-click mouse cursor does not work on desk 0 but does on 1, 2 and 3. https://fvwmforums.org/t/desktopname-0/4594

I did a test on 1.1.0. Desk 0 is not accessible with the mouse cursor on a pager.

######### DesktopName 0 Web DesktopName 1 Email DesktopName 2 Office

DesktopSize "2 1" ## (columns - rows)

Module FvwmPager VdeskPager 0 2 ## (desk number - number of desks)

DestroyModuleConfig VdeskPager: VdeskPager: Geometry 150x240-0+0 VdeskPager: Rows 3 ## (page rows) VdeskPager: Colorset 15 ## RootTransparent requires Picom. VdeskPager: HilightColorset 17 ## (active page background) VdeskPager: BalloonColorset 10 ## (font color) VdeskPager: WindowColorsets 13 18 ## (inactive - active apps) VdeskPager: Font "xft:Sans:size=12:antialias=True" VdeskPager: WindowBorderWidth 1 VdeskPager: BalloonStringFormat %c VdeskPager: BallonYOffset +2 VdeskPager: Window3dBorders VdeskPager: UseSkipList # hides modules *VdeskPager: MiniIcons

Style VdeskPager NoTitle, !Handles, Borders, BorderWidth 1, BorderColorset 6, Sticky, WindowListSkip, FixedSize, !Iconifiable

somiaj commented 6 months ago

Have you tried the current main branch? There was a few bugs with parsing screen numbers causing issues with virtual pages that have been fixed in the main branch, so just double check you still see this problem in the main branch.

rasatpc commented 6 months ago

The problem is still there. Also, I updated my fvwm3 fork. "This branch is up to date with fvwmorg/fvwm3:main". fvwm3-1.0.9 works fine.

ThomasAdam commented 6 months ago

Hi @rasatpc

Please try the ta/gh-957 branch, where I believe this should now be fixed.

rasatpc commented 6 months ago

Doesn't work. The pager (VdeskPager) does not appear.

rasatpc commented 6 months ago

Pager disappearing was a config problem. After fixing it, still Desk 0 is not assessable with mouse cursor. Also, tested with default-config.

ThomasAdam commented 6 months ago

It works fine for me. Can you suggest ways of how I can reproduce this if it's still not working for you, @rasatpc ?

rasatpc commented 6 months ago

I am using a laptop with no attached monitor.

  1. Start Fvwm with empty .fvwm/ folder.
  2. Add this test pager script to an empty file name config.

Colorset 2 fg #ffffff, bg #2b4e5e, hi, sh, Plain, NoShape Colorset 6 fg #ffffff, bg #88b2b1, hi, sh, Plain, NoShape Colorset 7 fg #999999, bg #cbdcca, hi, sh, Plain, NoShape Colorset 10 fg #ffffff, bg #2b4e5e, hi #aaaaaa, sh #999999, Plain, NoShape

DesktopName 0 Web DesktopName 1 Email DesktopName 2 Office

DesktopSize "2 1"

Module FvwmPager TestPager 0 2

DestroyModuleConfig TestPager: TestPager: Geometry 150x240-0+0 TestPager: Rows 3 TestPager: HilightColorset 7 TestPager: BalloonColorset 10 TestPager: WindowColorsets 6 2 TestPager: UseSkipList TestPager: MiniIcons

Style TestPager NoTitle, !Handles, Sticky, WindowListSkip

  1. Logout and login.

Click Email desk and go back to Web desk. With mouse cursor can't access Web desk. Only works with command GoToDesk 0 0 0.

rasatpc commented 6 months ago

Didn't see yesterday's ta/gh-957 update. Desk 0 works but with right-click. Change to left-click.

ThomasAdam commented 6 months ago

Well, this is working just fine for me -- so I'll merge this soon. Unless there's any other problems?

rasatpc commented 6 months ago

I did one test with a fresh install with main and ta-gh-957 branch. And, new login to a clean desk with RightPanel.

*main branch with mouse cursor

  1. Desk 0 works fine until going to other Desk (1,2,3)
  2. I added one xterm in each desk to see any desk changes. There are problems.

*ta-gh-957 branch

  1. Mini-window doesn't appear
  2. With FvwmConsole run Module FvwmPager and mini-window appears.

I will wait for the merge.

ThomasAdam commented 6 months ago

Hi @rasatpc

OK, there were actually two things going on here -- but your original bug report didn't clarify much.

As it happens though, on the ta/gh-957 branch, you should now find that switching between desks using the RightPanel config works as expected.

Let me know how you get on, and if there's anything else related to this bug report which needs fixing.

rasatpc commented 6 months ago

Thanks, branch ta/gh-957 with default config and RightPanel, works fine. Also, the RightPager does fine that Mjaakko showed on forum. https://fvwmforums.org/t/desktopname-0/4594/3

Desk left-click and mini-window is ok on ta/gh-957.

rasatpc commented 6 months ago

Lastly, default config, I did a test on ta/gh-957 with the VdeskPager that I used as a sample. in this report. To change desk between Web, Email, and Office only right-click. The page change is ok with left-click.

First, check if the VdeskPager config is correct.