search

fvwmorg / fvwm3

FVWM version 3 -- the successor to fvwm2
Other
511 stars 78 forks source link

Workspace number at changes -- system freeze #997

Closed rasatpc closed 5 months ago

rasatpc commented 6 months ago

Expected Behaviour

This config has worked well until fvwm3 1.1.0 release. https://fvwmforums.org/t/any-idea-to-display-the-workspace-number-at-changes/1822/6

It was copied and modified to a PageIndicator script. https://github.com/rasatpc/Fvwm-KISe/blob/main/core/1Functions/PageIndicator/deskPgNo.sys

Fvwm3 1.1.0 makes FvwmPager flicker and freezes the system for a few seconds. Any action freezes the whole system.

I have not been able to pinpoint the issue, but it seems to do with Module FvwmEvent

Is it a bug or a config error?

ThomasAdam commented 6 months ago

Hi @rasatpc

Yes, it's a bug. I think I need to check the DesktopSize broadcast module issue as this implicitly sends a M_NEW_PAGE packet each time.

That being said, the way you've written this panel is written to spawn itself on a new_page event each time seems weird to me. I would instead use a single sticky FvwmButtons instance, and use SendToModule to change the button's text.

ThomasAdam commented 6 months ago

@rasatpc

Please can you try compiling fvwm3 on the ta/gh-997 branch? Hopefully that fixes this problem for you.

rasatpc commented 6 months ago

fvwm3 on the ta/gh-997 branch

Slightly better with milder freeze.

ThomasAdam commented 6 months ago

So it does help?

Good.

Whatever you're referring to re UseSkipList, has nothing to do with this issue.

rasatpc commented 6 months ago

Slight help, but still freezes,

Ok, UseSkipList I check later after this system freeze is solved.

ThomasAdam commented 6 months ago

I don't have any freezes here.

Can you see if there's other factors here which could be contributing to this?

rasatpc commented 6 months ago

Earlier I test with all Kise configs. Now, default config with RightPanel. FvwmConsole: Read deskPgNo.sys

RightPanel's FvwmPager mini-windows are shaking, stops and system freeze.

Did you make any new changes in ta/gh-997 in 3 hours?

ThomasAdam commented 6 months ago

No, but I have just pushed another fix on that branch -- please git pull and try again.

Note also that your config example is still going to spawn a new FvwmButtons each time there's a new_page event. You should rewrite it per my earlier suggestion -- until you do, you will notice flickering as fvwm is trying to deal with that.

rasatpc commented 6 months ago

Thank you, the Page Indicator works fine.

use a single sticky FvwmButtons instance, and use SendToModule to change the button's text.

I don't understand those technical words. Will ask tomorrow. It is late here in Helsinki.... 01:35. Good night.