fw42 / cubecomp

WCA Rubik's Cube competition website hosting
https://cubecomp.de/
MIT License
10 stars 4 forks source link

Event overview has wrong registration numbers #199

Closed Laura-O closed 9 years ago

Laura-O commented 9 years ago

The numbers for registrations in the events table is wrong. According to the dashboard there are 97 competitors registered for German Nationals on Sunday, but 98 compete in 3x3. I assume all registrations are counted, also non-active registrations.

fw42 commented 9 years ago

I assume you mean this:

screen shot 2015-08-19 at 7 42 10 pm

If so, then you are right, that includes all competitors (even new and cancelled ones). If you click the little magnifying glass icon for "Show registrations", you can see which ones are not confirmed.

Do you think it should be changed to only show the ones that are confirmed, i.e. not new and not cancelled? Or maybe confirmed and new but not cancelled?

fw42 commented 9 years ago

Also the number includes the waiting ones... Not sure if that comes up a lot, but might also be confusing... so if it says "20 (10 waiting)" then that's a total of 20, not 30.

Let me know what you think makes the most sense and I will change it.

Laura-O commented 9 years ago

For me, showing the registered and confirmed (not new, not canceled, not waiting) makes most sense. At least that is how I interpreted it in the past. ;-)

Do you agree, @SAuroux?

SAuroux commented 9 years ago

I agree. ;)

2015-08-21 13:19 GMT+02:00 Laura Ohrndorf notifications@github.com:

For me, showing the registered and confirmed (not new, not canceled, not waiting) makes most sense. At least that is how I interpreted it in the past. ;-)

Do you agree, @SAuroux https://github.com/SAuroux?

— Reply to this email directly or view it on GitHub https://github.com/fw42/cubecomp/issues/199#issuecomment-133375721.